Repository navigation
feat(retain): add retain method - #366
Merged
Merged
Conversation
HellButcher
force-pushed
the
feat/retain
branch
2 times, most recently
from
September 15, 2026 10:41
31a2549 to
cc2f119
Compare
Kerollmops
requested changes
Sep 15, 2026
Kerollmops
left a comment
Kerollmops
left a comment
Member
There was a problem hiding this comment.
Hey @HellButcher 👋
Thank you for the nice addition. Would you mind fixing the CI errors, please?
HellButcher
force-pushed
the
feat/retain
branch
from
September 15, 2026 16:27
cc2f119 to
7fde537
Compare
Kerollmops
requested changes
Sep 16, 2026
Kerollmops
left a comment
Kerollmops
left a comment
Member
There was a problem hiding this comment.
Final little clippy issue now 👀 😊
HellButcher
force-pushed
the
feat/retain
branch
from
September 17, 2026 14:16
7fde537 to
6a8792c
Compare
HellButcher
force-pushed
the
feat/retain
branch
from
September 17, 2026 14:41
6a8792c to
ba7647d
Compare
adds a `retain(&mut self, f: FnMut(u32) -> bool)` method to `RoaringBitmap` and `RoaringTreemap`. It works similar to `Vec::retain`.
HellButcher
force-pushed
the
feat/retain
branch
from
September 17, 2026 14:44
ba7647d to
9362c0d
Compare
Kerollmops
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a
retain(&mut self, f: FnMut(u32) -> bool)method toRoaringBitmapandRoaringTreemap.It works similar to
Vec::retain.